Re: [PATCH] staging: tidspbridge: enable watchdog by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Feb 10, 2012 at 7:18 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote:
>> Hi,
>>
>> On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras
>> <felipe.contreras@xxxxxxxxx> wrote:
>> >> Again, I'm totally confused as to _WHY_ this needs to be y.  What is
>> >> causing this oops without it?  If an oops is happening, then shouldn't
>> >> this be a strict dependancy?  Why allow it to be disabled at all if it
>> >> can break your box if you don't enable it?
>> >
>> > It's not an oops, it's a warning, and again, it depends on the
>> > firmware being used. We don't have control over that, and we have no
>> > way to detect if this feature is there. It's up to the user.
>>
>> I have been thinking more into it, how about looking for a WDT symbol
>> inside the baseimage to decide whether to turn ON/OFF WDT3, this would
>> mean that the code is always compiled in, but the decision to turn it
>> on/off is made at runtime.
>
> I totally don't understand, why not just silence the warning properly
> then?

The warning doesn't come from the driver, and AFAIK it's a valid
warning. Now, I haven't explored the code, so I don't know what's
going on, I just know Omar said this fixes the warning, and that
there's no easy way around it.

> I fail to understand why this warning happens,

I don't know either, I just know enabling TIDSPBRIDGE_WDT3 fixes it.

> why it depends on the firmware,

Because it just does.

Does your firmware have WDT? Yes => TIDSPBRIDGE_WDT3 on, No =>
TIDSPBRIDGE_WDT3 off.

What is so complicated about this?

> and why you can't detect it at runtime to not do it.

The DSP "firmwmare" is an operating system. You even run Linux on it.

We just don't know if has WDT support or not. Omar is familiar with
the code regarding the WDT, and he said it was not easy to detect if
enabling WDT failed or not.

> And how it all ties into a kconfig option...

Some people want it, some people don't.

-- 
Felipe Contreras
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux