Re: [PATCH 2/3] staging:iio:kfifo_buf: Fix potential buffer overflow in iio_read_first_n_kfifo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Dec 08, 2011 at 06:35:52PM +0100, Lars-Peter Clausen wrote:
> n is the number of bytes to read, not the number of samples. So if there is
> enough data available we will write to the userspace buffer beyond its bounds.
> Fix this by copying n bytes maximum. Also round n down to the next multiple of
> the sample size, so we will only read complete samples. If the buffer is too
> small to hold at least one sample return -EINVAL.
> 
> Also update the documentation of read_first_n to reflect the fact that 'n' is
> supposed to be in bytes and not in samples.
> 
> Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
>  drivers/staging/iio/buffer.h    |    2 +-

This patch no longer applies to my tree, care to refresh it and resend
it?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux