Re: [patch -next] [media] Staging: as102: pass device to dev_err()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi,

On 11/16/2011 09:25 AM, Dan Carpenter wrote:
> We'd oops if we hit this dev_err() and also gcc complains:
> 
> drivers/staging/media/as102/as102_drv.c: In function ‘as102_dvb_register’:
> drivers/staging/media/as102/as102_drv.c:223:3:
> 	warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
> 
> Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c
> index b8adfd2..beacb2c 100644
> --- a/drivers/staging/media/as102/as102_drv.c
> +++ b/drivers/staging/media/as102/as102_drv.c
> @@ -220,7 +220,7 @@ int as102_dvb_register(struct as102_dev_t *as102_dev)
> 
>   	ret = dvb_dmx_init(&as102_dev->dvb_dmx);
>   	if (ret<  0) {
> -		dev_err("%s: dvb_dmx_init() failed: %d\n", __func__, ret);
> +		dev_err(dev, "%s: dvb_dmx_init() failed: %d\n", __func__, ret);
>   		goto edmxinit;
>   	}

Thanks for the patch. However I have addressed the issue already and similar patch
is sitting in the patchwork system, waiting for merging. Please see
http://patchwork.linuxtv.org/patch/8355/


-- 
Regards,
Sylwester
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [X.Org]     [Yosemite Backpacking]

  Powered by Linux