Re: [PATCH 13/29] staging: brcm80211: revisited END_FOREACH_BSS macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Jul 22, 2011 at 08:57:00PM +0200, Arend van Spriel wrote:
> @@ -3345,7 +3345,7 @@ void brcms_c_init(struct brcms_c_info *wlc)
>  	FOREACH_BSS(wlc, i, bsscfg)
>  		brcms_c_set_mac(bsscfg);
>  		brcms_c_set_bssid(bsscfg);
> -	END_FOREACH_BSS
> +	END_FOREACH_BSS()

These would look nicer with a semicolon on the end.

	END_FOREACH_BSS();

That looks like c.

I quite liked my way with the extra { } chars.

	FOREACH_BSS(wlc, i, bsscfg) {
		brcms_c_set_mac(bsscfg);
		brcms_c_set_bssid(bsscfg);
	} END_FOREACH_BSS();

Emacs gets the indenting wrong without the braces.  We use that
style of for each loop in the Sparse project.

But I'm fairly sick of this macro so at this point, I'm fine with
whatever.  :P

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

Add to Google Powered by Linux