Re: [PATCH] staging: nvec: convert to use platform register and mfd cells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sun, 2011-07-24 at 21:56 +0200, Marc Dietrich wrote:
> This patch converts the nvec to use mfd cells and improves the
> registration of the platform driver. The child drivers are also
> converted to use mfd cells and platform registration.

trivia:

> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
[]
> @@ -23,6 +23,7 @@
[]
>  static unsigned char EC_DISABLE_EVENT_REPORTING[] =	{'\x04','\x00','\x00'};

Please use const where appropriate.

> @@ -31,6 +32,25 @@ static unsigned char EC_GET_FIRMWARE_VERSION[] =	{'\x07','\x15'};\
[]
> +static struct mfd_cell nvec_devices[] = {

const?

> +	{
> +		.name	= "nvec-kbd",
> +		.id	= 1,
> +	},
[]
> @@ -367,20 +380,21 @@ static int __devinit tegra_nvec_probe(struct platform_device *pdev)
>  	INIT_WORK(&nvec->rx_work, nvec_dispatch);
>  	INIT_WORK(&nvec->tx_work, nvec_request_master);
>  
> +	err = request_irq(nvec->irq, nvec_interrupt, 0, "nvec", nvec);
> +	if (err) {
> +		dev_err(nvec->dev, "couldn't request irq");

Add terminating "\n" please.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux