Re: [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On 04/05/2011 09:58 AM, Henry Ptasinski wrote:
The basename-apiversion-codeversion construction for firmware filenames is not
used by most other firmware files, adds complexity, and is not providing any
value.  Renamed the firmware files using just basename-apiversion and fixed
WHENCE to have correct names and path to these files.
  WHENCE                                             |   12 ++++++------
  ...llmac-4-218-248-5.bin =>  bcm4329-fullmac-4.bin} |  Bin 269595 ->  269595 bytes
  ...llmac-4-218-248-5.txt =>  bcm4329-fullmac-4.txt} |    0
  brcm/{bcm43xx-0-610-809-0.fw =>  bcm43xx-0.fw}      |  Bin 97376 ->  97376 bytes
  ...bcm43xx_hdr-0-610-809-0.fw =>  bcm43xx_hdr-0.fw} |  Bin 180 ->  180 bytes
  5 files changed, 6 insertions(+), 6 deletions(-)
  rename brcm/{bcm4329-fullmac-4-218-248-5.bin =>  bcm4329-fullmac-4.bin} (100%)
  rename brcm/{bcm4329-fullmac-4-218-248-5.txt =>  bcm4329-fullmac-4.txt} (100%)
  rename brcm/{bcm43xx-0-610-809-0.fw =>  bcm43xx-0.fw} (100%)
  rename brcm/{bcm43xx_hdr-0-610-809-0.fw =>  bcm43xx_hdr-0.fw} (100%)

diff --git a/WHENCE b/WHENCE
index 6632b85..c81a2b4 100644
--- a/WHENCE
+++ b/WHENCE
@@ -1433,19 +1433,19 @@ Licence:


-Driver: brcm80211 - Broadcom 802.11n wireless LAN driver.
+Driver: brcmsmac - Broadcom 802.11n softmac wireless LAN driver.

-File: brcm/bcm43xx-0-610-809-0.fw
-File: brcm/bcm43xx_hdr-0-610-809-0.fw
+File: brcm/bcm43xx-0.fw
+File: brcm/bcm43xx_hdr-0.fw

  Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.


-Driver: brcm80211 - Broadcom 802.11n wireless LAN driver.
+Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.

-File: bcm4329-fullmac-4-218-248-5.bin
-File: bcm4329-fullmac-4-218-248-5.txt
+File: brcm/bcm4329-fullmac-4.bin
+File: brcm/bcm4329-fullmac-4.txt

  Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details.

diff --git a/brcm/bcm4329-fullmac-4-218-248-5.txt b/brcm/bcm4329-fullmac-4.txt
similarity index 100%
rename from brcm/bcm4329-fullmac-4-218-248-5.txt
rename to brcm/bcm4329-fullmac-4.txt

Given all the problems we in the b43 community have had with Broadcom firmware, I certainly applaud every instance where the company makes firmware freely available and redistributable.

I also endorse removing the version number from the firmware name; however, I see a fundamental flaw in the present submission. Both brcmsmac and its predecessor brcm80211 have been included in mainline and compat-wireless, have been widely distributed, and have a number of users. This change will break the system of every one of them - including mine. My proposed solution is to do the rename as done in this patch, but also include links to the new name from every name used in any distributed version. After approximately two years, the links can be removed, but they are needed now.

The brcmsmac/brcm80211 driver already has a PR problem due to the instabilities and the system lockups. Adding this kind of system breakage would do even more damage to its reputation.


devel mailing list

[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux