Re: [PATCH V1] regulator: fixed: dt: add property for gpio open drain flag
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Monday 07 May 2012 08:35 PM, Stephen Warren wrote:
On 05/07/2012 04:28 AM, Laxman Dewangan wrote:Add property for the gpio flag open drain when registering fixed regulator. diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt ... +- gpio-open-drain: GPIO is open drain type. + If this property is missing then default assumption is false.Given that there's a GPIOF_OPEN_DRAIN, isn't the GPIO specifier in the gpio property meant to encode this somehow (the format is up to the GPIO controller's binding) - the flags are returned by of_get_named_gpio_flags(). (especially given you asked me off-list about updating the GPIO binding documentation with information about the flags that Tegra's binding documented for this)
gpio of binding does not explain that there is always gpio flag (GPIOF_*) in gpio cell argument. It is up to the chip specific gpio driver how they implement the argumnets. For the example of gpio-samsung have the 4 argument list and all are for different purpose. And if they want to set pin as open drain, it will not be possible on their argument list as none of the cell argument reflect to GPIOF_* flag. For the case of tegra, there is no of_xlate() implementation and hence it is by default return as GPIOF_.
And the client driver which is indpendent of chip specific gpio driver should able to handle this.
-- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[Site Home] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Linux FS] [Photo] [Yosemite] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]