|
|
|
Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module. | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Tuesday 08 May 2012, Andreas Westin wrote:
> This adds the required platform data and calls to enable
> the CRYP/HASH driver.
>
> index 15a0f63..a69db46 100644
> --- a/arch/arm/mach-ux500/id.c
> +++ b/arch/arm/mach-ux500/id.c
> @@ -17,7 +17,10 @@
> #include <mach/hardware.h>
> #include <mach/setup.h>
>
> +#include <linux/module.h>
> +
> struct dbx500_asic_id dbx500_id;
> +EXPORT_SYMBOL(dbx500_id);
>
> static unsigned int ux500_read_asicid(phys_addr_t addr)
> {
This needs an explanation! Why do you export an internal data structure
to non-GPL modules?
On a more general topic, I wonder if it's really necessary to add new
devices to the legacy probing path in mach-ux500. Why not make new drivers
for this platform dt-only, so we don't need to add code now that we will
have to remove again in one or two kernel releases?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html