Re: [PATCH] talitos: handle descriptor not found in error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, 18 Oct 2011 09:36:18 +0200
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Kim Phillips <kim.phillips@xxxxxxxxxxxxx> wrote:
> > The CDPR (Current Descriptor Pointer Register) can be unreliable
> > when trying to locate an offending descriptor.  Handle that case by
> > (a) not OOPSing, and (b) reverting to the machine internal copy of
> > the descriptor header in order to report the correct execution unit
> > error.
> > 
> > Note: printing all execution units' ISRs is not effective because it
> > results in an internal time out (ITO) error and the EU resetting its
> > ISR value (at least when specifying an invalid key length on an SEC
> > 2.2/MPC8313E).
> > 
> > Reported-by: Sven Schnelle <svens@xxxxxxxxxxxxxx>
> > Signed-off-by: Kim Phillips <kim.phillips@xxxxxxxxxxxxx>
> > ---
> > please test, as it seems I cannot reproduce the descriptor not found
> > case.
> 
> So what's the verdict Kim, should I take this patch or not?

sure - I've verified it does at least satisfy Sven's shouldn't-oops
comment.

btw, can you take a look at applying this also?:

http://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg05996.html

It makes IPSec AH work for async crypto implementations.

Thanks,

Kim

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

Add to Google