- Subject: Re: [PATCH v1.3 2/4] key: add tpm_send command
- From: David Howells <dhowells@xxxxxxxxxx>
- Date: Fri, 12 Nov 2010 22:11:39 +0000
- Cc: dhowells@xxxxxxxxxx, Rajiv Andrade <srajiv@xxxxxxxxxxxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, keyrings@xxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>
- In-reply-to: <1289599613.4341.64.camel@xxxxxxxxxxxxxxxxxxxxx>
- Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
David Safford <safford@xxxxxxxxxxxxxx> wrote:
> David, does this look ok to you? If so, I will do two patches, one to
> fix the helper name throughout the existing tpm.c, and then a new
> version of the tpm_send patch which uses the new name.
I prefer my suggestion: Wrapping the module_put() up so that you don't see it
directly. Then you don't need to alter tpm_chip_find_get(). I'll argue that
you don't need to know how tpm_chips are got/put, except in the code that
wraps it.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Kernel]
[Gnu Classpath]
[Gnu Crypto]
[DM Crypt]
[Netfilter]
[Bugtraq]