Re: [PATCH] cgroup: fix device deny of DEV_ALL
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 22/05/12 10:08, Serge E. Hallyn wrote:
At line 135, there is if (walk->type == DEV_ALL) goto remove; I wonder if that was meant to be 'if (wh->type == DEV_ALL)'. That seems to fit better with what I would have meant to have happen. But it's already handled by line 342. So I think deleting lines 135-136 might be best. What do you think?
Hi Serge, If we expect nothing changed ('a *:* rwm' doesn't change), delete 135-136 will be ok. But I have explained my patch in another email, I also think it's unnecessary to remove 'a *:* rwm' before executing: @ echo 'b 253:3 rw'> devices.deny -- Amos. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
[Cgroups] [Netdev] [Linux Wireless] [Kernel Newbies] [Memory] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Photo] [Yosemite] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Find Someone Nice] [Samba] [Video 4 Linux] [Computer Add-ons]