Re: fscache: bug report: dereferencing before checking

[David Howells <dhowells@xxxxxxxxxx>]

Dan Carpenter <error27@xxxxxxxxx> wrote:

> Can "page" be NULL here?

Hmmm...  Interesting question.  I'm not sure it can be NULL.

radix_tree_gang_lookup_tag() finds pages in the tree that have a particular
tag set, and returns the number of pages it has selected.  If that number is
!= 1, then I don't proceed with accessing the array.

So I think the tests of page later are unnecessary.

David

--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cachefs