- Subject: Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available
- From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
- Date: Sun, 8 Nov 2009 16:50:00 +0000
- Cc: Andreas Dilger <adilger@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxx>, Kysela <perex@xxxxxxxx>, Jan@xxxxxxxxxxxxxxxxxxxxx, Stefan Weinhuber <wein@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxx>, linux-cachefs@xxxxxxxxxx, WANG Cong <wangcong@xxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, netfilter@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Engelhardt <jengelh@xxxxxxxxxx>, Bjorn Helgaas <bjorn.helgaas@xxxxxx>, And@xxxxxxxxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Stoyan Gaydarov <stoyboyker@xxxxxxxxx>, Kyle McMartin <kyle@xxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Joe Perches <joe@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, Jaroslav@xxxxxxxxxxxxxxxxxxxxx, Kergon <agk@xxxxxxxxxx>, Banks <gnb@xxxxxxxxxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Helge Deller <deller@xxxxxx>, Samuel@xxxxxxxxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx>, van de Ven <arjan@xxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, Steve@xxxxxxxxxxxxxxxxxxxxx, Christof Schmitt <christof.schmitt@xxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, linux390@xxxxxxxxxx, Frederic Weisbecker <fweisbec@xxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, Andre Noll <maan@xxxxxxxxxxxxxxx>, ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx, Jens Axboe <jens.axboe@xxxxxxxxxx>, Adam Belay <abelay@xxxxxxx>, Stefan Haberland <stefan.haberland@xxxxxxxxxx>, Roman Hoog Antink <rha@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Dike <jdike@xxxxxxxxxxx>, Henrique de Moraes Holschuh <ibm-acpi@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Jeff@xxxxxxxxxxxxxxxxxxxxx, ré Goddard Rosa <andre.goddard@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxx>, Roel Kluin <roel.kluin@xxxxxxxxx>, Andrey Borzenkov <arvidjaar@xxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Pavel Roskin <proski@xxxxxxx>, Jan Kara <jack@xxxxxxx>, Neil Brown <neilb@xxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Julia Lawall <julia@xxxxxxx>, Alasdair@xxxxxxxxxxxxxxxxxxxxx, Daire Byrne <Daire.Byrne@xxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Arjan@xxxxxxxxxxxxxxxxxxxxx, Andrea Righi <righi.andrea@xxxxxxxxx>, Ortiz <samuel@xxxxxxxxxx>, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx, Sitsofe Wheeler <sitsofe@xxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, Greg@xxxxxxxxxxxxxxxxxxxxx, Mikulas Patocka <mpatocka@xxxxxxxxxx>, user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Richard Purdie <rpurdie@xxxxxxxxx>
- In-reply-to: <c7d3b02b5e28eaa54a5360d57dfd177c44320187.1257602781.git.andre.goddard@xxxxxxxxx>
- Reply-to: Linux filesystem caching discussion list <linux-cachefs@xxxxxxxxxx>
On Sat, 7 Nov 2009 13:16:18 -0200
André Goddard Rosa <andre.goddard@xxxxxxxxx> wrote:
> On the following sentence:
> while (*s && isspace(*s))
> s++;
Looks fine but for one thing: it's actually shorter inline than moved
into /lib so at the very least it should be a header inline not a
function call.
Second minor comment. Although it never made it into the final ANSI C,
the proposed name (and the one used in a lot of other non Linux code for
this) is stpblk().
Alan
--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cachefs
[Linux Resources]
[LARTC]
[Bugtraq]
[Yosemite Forum]
[Photo]