Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sat,  7 Nov 2009 13:16:18 -0200
André Goddard Rosa <andre.goddard@xxxxxxxxx> wrote:

> On the following sentence:
>     while (*s && isspace(*s))
>         s++;

Looks fine but for one thing: it's actually shorter inline than moved
into /lib so at the very least it should be a header inline not a
function call.

Second minor comment. Although it never made it into the final ANSI C,
the proposed name (and the one used in a lot of other non Linux code for
this) is stpblk().

Alan

--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cachefs

[Linux Resources]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

Powered by Linux