Re: [PATCH v3] Btrfs: fix tree mod logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2013 at 11:19 PM, Holger Hoffstätte
<holger.hoffstaette@xxxxxxxxxxxxxx> wrote:
> On Fri, 20 Dec 2013 15:17:46 +0000, Filipe David Borba Manana wrote:
>
> [..patch..]
>
> I applied this to 3.12.6 and was rewarded with:
>
> *fs/btrfs/ctree.c: In function 'tree_mod_log_set_node_key':
> *fs/btrfs/ctree.c:924:2: error: implicit declaration of function
> '__tree_mod_log_insert_key' [-Werror=implicit-function-declaration]
> *  ret = __tree_mod_log_insert_key(fs_info, eb, slot,
> *  ^
> *cc1: some warnings being treated as errors
> *scripts/Makefile.build:308: recipe for target 'fs/btrfs/ctree.o' failed
>
> Said function prototype is nowhere to be found, only the regular non-
> scoped function. Did you just miss this call? Changing the call to the
> remaining tree_mod_log_insert_key() looks like what was intended and
> compiles, but I wanted to check before I burn the house down. :)

Did you apply first the patch titled "Btrfs: return immediately if
tree log mod is not necessary" ?
It depends on that one, and both are targeted against btrfs-next
repository from Josef. Didn't try 3.12.* at all.

Thanks


>
> -h
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux