[PATCH] Btrfs-progs: we need to have the string null terminated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bug:
-------------
btrfs subvolume list / -a
ID 258 gen 4226 top level 384 path media/smbshare
::
btrfs subvolume list /home -a
ID 258 gen 4226 top level 5 path <FS_TREE>/__active/media/smbshare4.snap

In the first command's output, this path is printed correctly, however
in the second output it has "4.snap" appended, similar to the names of
the snapshots I made 22 hours ago.
------------

Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
Reported-by: Brendan Hide <brendan@xxxxxxxxxxxxxxxxx>
---
 btrfs-list.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/btrfs-list.c b/btrfs-list.c
index e5f0f96..5acba78 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -633,6 +633,7 @@ static int resolve_root(struct root_lookup *rl, struct root_info *ri,
 			len = strlen(full_path);
 			tmp = malloc(len + add_len + 2);
 			memcpy(tmp + add_len + 1, full_path, len);
+			tmp[len + add_len + 1] = '\0';
 			tmp[add_len] = '/';
 			memcpy(tmp, p, add_len);
 			free(full_path);
-- 
1.8.1.227.g44fe835

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux