Re: [PATCH 02/10] Btrfs: fix missing inherited flag in rename

[David Sterba <dave@xxxxxxxx>]

On Thu, Jun 14, 2012 at 04:23:18PM +0800, Liu Bo wrote:
> When we move a file into a directory with compression flag, we need to
> inherite BTRFS_INODE_COMPRESS and clear BTRFS_INODE_NOCOMPRESS as well.

Right.

> But if we move a file into a directory without compression flag, we need
> to clear both of them.

Right. And now thinking about it, the _NOCOMPRESS should be honored as
well, not dropped.

The expected use here is to set a NOCOMP flag on the directory and let
it inherit for all newly created files/dirs

> It is the way how our setflags deals with compression flag, so keep
> the same behaviour here.

Yeah, keep it the same :)

Priority of all the compression flags may not be clear, the NOCOMPRESS
has precedence over COMPRESS, as it attempts to avoid pointless
file compression. Both per-file flags are preferred over compression
mount option.


david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html