Re: [PATCH] blktrace: disallow -o when using multiple devices
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 09/20/2010 10:35 AM, Alan D. Brunelle wrote:
On 09/16/2010 05:17 PM, Brett Russ wrote:On 09/16/2010 10:20 AM, Brett Russ wrote:-Wouldn't it be a good idea to just add<prefix> before the filename(s) that would have been created in either the single or multiple device case? I.e. in the multiple device case, how about "<prefix>.<device>.blktrace.<cpu>"? That way the program always does what the user wants, no special case documentation required.I just now read in full your second email on the original thread where you mentioned doing this solution, sorry for the redundancy. You expressed reservations about it, wondering what else it might break. I'd suggest we make the change and test it, rather than having a "-o" option with limited utility? I imagine the biggest question mark is how blkparse handles it. -BrettI'm not so sure about this Brett - people may have scripts out there that depend on the current semantics. I'd be OK with doing it if Jens thought this was a minor concern...
As long as the change only affected output of multiple devices with "-o", which doesn't work today, then I'd think no scripts could be affected.
Thanks, Brett -- To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html