Re: Re: Re: [PATCH] blktrace: fix to trace a partition, instead of only disk

[Jens Axboe <jens.axboe@xxxxxxxxxx>]

On Wed, Dec 31 2008, Shawn Du wrote:
> >Very nice! The only problem with this is that we have actions that are,
> >by definition, per device. So we probably want to include any sector
> >that is within the range of the partition, AND a zero sector. So that
> >means changing act_log_check() to something ala:
> >
> >-       if (sector < bt->start_lba || sector > bt->end_lba)
> >+       if (!sector || sector < bt->start_lba || sector > bt->end_lba)
> >                return 1;
> >
> >in pseudo patch form.
> 
> Thank you sir. And perhaps, we change in __blk_add_trace():
> 
> -	if (unlikely(act_log_check(bt, what, sector, pid)))
> +	if (act_log_check(bt, what, sector, pid))

Sure, lets get rid of it.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-btrace" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html