Re: [PATCH] btt: fix missing cleanup call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Aaron Carroll wrote:
> clean_args() exists but is never called, thus any files opened in args remain
> open while the buffers backing those files are closed.
> 
> Signed-off-by: Aaron Carroll <aaronc@xxxxxxxxxxxxxxxxxx>
> ---
>  btt/bt_timeline.c |    1 +
>  btt/globals.h     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/btt/bt_timeline.c b/btt/bt_timeline.c
> index 981b909..17a1b23 100644
> --- a/btt/bt_timeline.c
> +++ b/btt/bt_timeline.c
> @@ -92,6 +92,7 @@ int main(int argc, char *argv[])
>  	free(input_name);
>  	if (output_name) free(output_name);
>  
> +	clean_args();
>  	clean_bufs();
>  
>  	return 0;
> diff --git a/btt/globals.h b/btt/globals.h
> index f6041de..486a3fc 100644
> --- a/btt/globals.h
> +++ b/btt/globals.h
> @@ -228,6 +228,7 @@ extern struct list_head cios;
>  
>  /* args.c */
>  void handle_args(int argc, char *argv[]);
> +void clean_args();
>  
>  /* devmap.c */
>  int dev_map_read(char *fname);
> 

Looks good, applied, thanks!

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-btrace" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Netdev]     [Linux Wireless]     [Kernel Newbies]     [Memory]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]     [Linux Resources]

Add to Google