Re: [PATCHv1 1/4] Bluetooth: Use standard HCI cmd timeout for RESET

[Marcel Holtmann <marcel@xxxxxxxxxxxx>]

Hi Andrei,

> Remove magic and use standard HCI cmd timeout
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> ---
>  net/bluetooth/hci_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index a2e15436c..e5a9a09 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -783,7 +783,7 @@ static int hci_dev_do_close(struct hci_dev *hdev)
>  	    test_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks)) {
>  		set_bit(HCI_INIT, &hdev->flags);
>  		__hci_request(hdev, hci_reset_req, 0,
> -			      msecs_to_jiffies(250));
> +			      msecs_to_jiffies(HCI_CMD_TIMEOUT));
>  		clear_bit(HCI_INIT, &hdev->flags);
>  	}

And while you are at it, can we please move over to put the
msecs_to_jiffies into the #define itself. So we get more readable code
here. A bunch of location have already been changed, but seems we have a
few leftovers.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html