Re: [RFC 2/8] gattrib: Fix g_attrib_set_mtu

[Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx>]

Hi Andre,

On Wed, Jun 6, 2012 at 8:40 PM, Andre Guedes <andre.guedes@xxxxxxxxxxxxx> wrote:
> 23 octets is the default (and minimum) ATT_MTU value. If someone tries
> to set ATT_MTU less than 23 octets g_attrib_set_mtu should fail (return
> FALSE). Additionally, there is no constraint regarding the maximum value
> of ATT_MTU, so we should not check for it.

Even though the spec does not mention a maximum ATT_MTU, we now need
to review and fix the ATT operations that mention limits on their PDU
(now that we removed the "artificial" 256 octect limit). Some I found:

- 3.2.9 Long Attribute Values (page 1839):

The maximum length of an attribute value shall be 512 octets.

- 3.4.4.2 Read By Type Response (page 1853):

The maximum length of an attribute handle-value pair is 255 octets, bounded
by the Length parameter that is one octet.

- 3.4.4.10 Read by Group Type Response (page 1861):

The maximum length of an Attribute Data is 255 octets, bounded by the Length
parameter that is one octet.

Also, what will happen to the ATT_MTU_MAX definition? Is it still
being used in other places?

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html