Re: [RFC 3/8] Bluetooth: Add l2cap_chan->ops->ready()
On Thu, 24 May 2012, Andrei Emeltchenko wrote:
Hi Ulisses, On Thu, May 24, 2012 at 08:31:15AM -0300, Ulisses Furquim wrote:Hi Andrei, On Thu, May 24, 2012 at 8:30 AM, Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx> wrote:Hi Ulisses, On Thu, May 24, 2012 at 08:17:23AM -0300, Ulisses Furquim wrote:+ void (*ready) (void *data);Again, why void *data ?I mean here that for fixed channels we do not need this function at this point since initialization is different.So? What do you mean? This needs to be generic, I think. It's an abstraction after all.Fixed channels do not have configuration phase, they are created CONNECTED (at least A2MP).And your proposal is?Fox fixed channels ready is not defined (at least now) so we can just use exact type, see my patch in a minute.
For l2cap_ops right now, every callback takes a void* except for alloc_skb. alloc_skb could get by with a void* by using l2cap_pi(sk)->chan.
In any case, I think we can agree that some consistency in l2cap_ops would be good! Either way will work because the void* can give the chan*, and with the chan* you have chan->data. Let's pick either void* or l2cap_chan* for the callbacks and stick with it.
-- Mat Martineau Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html