Re: [PATCH 1/2] Bluetooth: Move scope of state_to_string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi Marcel,

On Fri, Feb 17, 2012 at 10:12:10AM +0100, Marcel Holtmann wrote:
> Hi Andrei,
> 
> > > > Function state_to_string will be used in other files.
> > > > 
> > > so long term, we need to keep socket states inside l2cap_sock.c and
> > > L2CAP states inside l2cap_core.c. Since L2CAP core engine should use the
> > > states from the specification and not try to fit into socket states.
> > > 
> > > I see a little bit of value here in having them in the debug log, but
> > > making them public like this seems a big overhead. Did you measure the
> > > size difference. 
> > 
> > size show exactly the same size after applying this patch with my config.
> > (dynamic debug enabled)
> > 
> > size net/bluetooth/bluetooth.ko 
> >    text	   data	    bss	    dec	    hex	filename
> >  196404	  12912	    644	 209960	  33428	net/bluetooth/bluetooth.ko
> 
> then I am fine with this. Just send an updated patch against the latest
> tree.

If we don't want it to be in bluetooth.h I can export only function
declaration or put it in l2cap.h. What is better?

Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluez Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Bluez Devel]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]

Add to Google Powered by Linux