Re: bcache-tools: minor change for bcache-register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/27/2013 09:58 AM, Rolf Fokkens wrote:
> Would you consider another change as well:
> 
> --- bcache-tools-20130827.orig/bcache-register    2013-08-26 
> 23:46:19.000000000 +0200
> +++ bcache-tools-20130827/bcache-register    2013-08-27 
> 08:55:48.060477014 +0200
> @@ -1,4 +1,4 @@
>   #!/bin/sh
> -modprobe -qba bcache
> +/sbin/modprobe -qba bcache
>   test -f /sys/fs/bcache/register_quiet && echo "$1" > 
> /sys/fs/bcache/register_quiet
> 
> /sbin is not in the $PATH for utilities started from udev. For Fedora it 
> isn't anyway, but it won't harm other distro's neither.
> 

Hi all,

Pardon the interrupt, but this is not the case for Arch Linux:
https://www.archlinux.org/news/binaries-move-to-usrbin-requiring-update-intervention/

In my opinion, if modprobe *has* to be called with the exact path name,
it would probably be clearer to use `which modprobe` and then call the
result.

Just my two cents...

-- 
Alex | apyrgio@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux