Re: [PATCH 06/10] OMAP: PM debug: Add PRCM register dump support

[Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>]

Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> writes:

> "Aguirre Rodriguez, Sergio Alberto" <saaguirre@xxxxxx> writes:
>
>> Kevin,
>>
>>> -----Original Message-----
>>> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
>>> owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman
>>> Sent: Thursday, August 13, 2009 11:53 AM
>>> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; linux-arm@xxxxxxxxxxxxxxx
>>> Cc: linux-omap@xxxxxxxxxxxxxxx; Tero Kristo
>>> Subject: [PATCH 06/10] OMAP: PM debug: Add PRCM register dump support
>>> 
>>> From: Tero Kristo <tero.kristo@xxxxxxxxx>
>>> 
>>> Allows dumping out current register contents from the debug filesystem,
>>> and
>>> also allows user to add arbitrary register save points into code. Current
>>> register contents are available under debugfs at:
>>> 
>>> [debugfs]/pm_debug/registers/current
>>> 
>>> To add a save point, do following:
>>> 
>>> From module init (or somewhere before the save call, called only once):
>>>   pm_dbg_init_regset(n); // n=1..4, allocates memory for dump area #n
>>> 
>>> From arbitrary code location:
>>>   pm_dbg_regset_save(n); // n=1..4, saves registers to dump area #n
>>> 
>>> After this, the register dump can be seen under
>>> [debugfs]/pm_debug/registers/n
>>> 
>>> Signed-off-by: Tero Kristo <tero.kristo@xxxxxxxxx>
>>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
>>> ---
>>>  arch/arm/mach-omap2/pm-debug.c |  208
>>> ++++++++++++++++++++++++++++++++++++++++
>>>  arch/arm/mach-omap2/pm.h       |    4 +
>>>  2 files changed, 212 insertions(+), 0 deletions(-)
>>>  mode change 100644 => 100755 arch/arm/mach-omap2/pm-debug.c
>>>  mode change 100644 => 100755 arch/arm/mach-omap2/pm.h
>>
>> I guess these 755 mode changes weren't intentional... :)
>
> Indeed, they were not.  Thanks.
>

OK, fixed these locally but not worth a repost.  These will be updated in
the version pushed for pull request when reviewed/accepted.

Kevin



--
To unsubscribe from this list: send the line "unsubscribe linux-arm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html