Re: [PATCH] slimbus: Linux driver framework for SLIMbus.
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] slimbus: Linux driver framework for SLIMbus.
- From: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 4 Jun 2012 11:27:48 +0100
- Cc: davidb@xxxxxxxxxxxxxx, bryanh@xxxxxxxxxxxxxx, kheitke@xxxxxxxxxxxxxx, gclemson@xxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, rob@xxxxxxxxxxx, grant.likely@xxxxxxxxxxxx, rob.herring@xxxxxxxxxxx, ohad@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, linus.walleij@xxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, joerg.roedel@xxxxxxx, trenn@xxxxxxx, ak@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, devicetree-discuss@xxxxxxxxxxxxxxxx
- In-reply-to: <email@example.com>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 04, 2012 at 03:21:06AM -0700, Sagar Dharia wrote:
> > b) Similarly to (a) the driver may be probed before the device has
> > been given a logical address (LA). This makes sense in the case of
> > driver that turns on the device (say via gpio) once the bus has
> > booted. However, the driver then needs to sit and poll
> > slim_get_logical_addr() until the logical address.
> This is not the case anymore.
> While taking care of the comments for RFC, I have introduced a completion
> that will be signalled when LA is given to the device. The driver can wait
> on that completion (wait_enum) instead of polling.
This would mean that the thread the probe is happening in will be
blocked until the LA is assigned. That sounds like it might cause
problems, either slowing things down or worst case causing a deadlock.
Description: Digital signature
[Linux ARM Kernel]
[Linux for Sparc]
[Asterisk Internet PBX]