Re: [PATCH] clk: Fix race conditions between clk_set_parent() and clk_enable()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Saravana Kannan <skannan@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] clk: Fix race conditions between clk_set_parent() and clk_enable()
- From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
- Date: Tue, 15 May 2012 22:00:40 +0200
- Cc: Mike Turquette <mturquette@xxxxxxxxxx>, Arnd Bergman <arnd.bergmann@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, Andrew Lunn <andrew@xxxxxxx>, Rob Herring <rob.herring@xxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Paul Walmsley <paul@xxxxxxxxx>, Shawn Guo <shawn.guo@xxxxxxxxxxxxx>, Jamie Iles <jamie@xxxxxxxxxxxxx>, Richard Zhao <richard.zhao@xxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxxxxxx>, Amit Kucheria <amit.kucheria@xxxxxxxxxx>, Deepak Saxena <dsaxena@xxxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxxxx>
- In-reply-to: <4FB2B3AA.3010903@codeaurora.org>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 15, 2012 at 12:51:06PM -0700, Saravana Kannan wrote:
> >> ret = clk->ops->set_parent(clk->hw, i);
> >
> >You call ->set_parent while holding a spinlock. This won't work with i2c
> >clocks.
>
> I did account for that. I explained it in the commit text. Please
> let me know if any part of that is not clear or is not correct.
>
I missed this part in the commit log. I have no idea whether we can live
with this limitation though.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux ARM Kernel]
[Linux ARM]
[Linux Omap]
[Fedora ARM]
[Linux for Sparc]
[IETF Annouce]
[Security]
[Bugtraq]
[Linux OMAP]
[Linux MIPS]
[ECOS]
[Asterisk Internet PBX]
[Linux API]