Re: [PATCH] clk: Use a separate struct for holding init data.
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] clk: Use a separate struct for holding init data.
- From: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 26 Apr 2012 10:49:02 +0100
- Cc: Saravana Kannan <skannan@xxxxxxxxxxxxxx>, Mike Turquette <mturquette@xxxxxxxxxx>, Arnd Bergman <arnd.bergmann@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, Andrew Lunn <andrew@xxxxxxx>, Rob Herring <rob.herring@xxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Paul Walmsley <paul@xxxxxxxxx>, Shawn Guo <shawn.guo@xxxxxxxxxxxxx>, Jamie Iles <jamie@xxxxxxxxxxxxx>, Richard Zhao <richard.zhao@xxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxxxxxx>, Amit Kucheria <amit.kucheria@xxxxxxxxxx>, Deepak Saxena <dsaxena@xxxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxxxx>
- In-reply-to: <20120426083924.GE17184@pengutronix.de>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 26, 2012 at 10:39:24AM +0200, Sascha Hauer wrote:
> Can we please stop messing with the function prototypes? So you prefer
> passing a struct to clk_register which is fine and yes, it may have
> advantages. But do we really need to change the prototype? Why can't we
> just add a new function?
> I am generally open to do these changes, but we have come to the point
> where people actually want to *use* the clock framework instead of
> rebasing their stuff onto the latest patches.
Or at least wait until we've got somewhere with applying drivers so that
whoever is changing the APIs is responsible for updating at least the
in-tree drivers. This would minimise the pain for people who've been
sitting waiting to get their stuff in which seems helpful.
Description: Digital signature
[Linux ARM Kernel]
[Linux for Sparc]
[Asterisk Internet PBX]