Re: [patch] [media] gpio-ir-recv: a couple signedness bugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi Dan,

On 3/10/2012 2:28 PM, Dan Carpenter wrote:
There are couple places where we check unsigned values for negative.  I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
         if (pdata->gpio_nr<  0)
                 return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative

Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>


Reviewed-by: Trilok Soni <tsoni@xxxxxxxxxxxxxx>

---Trilok Soni

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

Add to Google