Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, 2011-12-01 at 21:03 +0000, Russell King - ARM Linux wrote:
> On Thu, Dec 01, 2011 at 12:49:58PM -0800, Daniel Walker wrote:
> > On Thu, 2011-12-01 at 20:35 +0000, Russell King - ARM Linux wrote:
> > > On Thu, Dec 01, 2011 at 12:25:47PM -0800, Daniel Walker wrote:
> > > > On Thu, 2011-12-01 at 20:19 +0000, Russell King - ARM Linux wrote:
> > > > > Now, the obvious question to ask now is this: as you sent your question,
> > > > > and Daniel obviously objects, was Daniel one of your respondants?  If
> > > > > not, then he carries some of the blame for this patch being created
> > > > > in the first place by having missed the email/not replied/etc.
> > > > > 
> > > > 
> > > > What if the people using the hardware aren't even on the list ? It's not
> > > > their fault is it?
> > > 
> > > Did you notice I mentioned six months?
> > 
> > Yeah I did notice..
> > 
> > > The way to remove non-broken code is:
> > > 1. to ask.  If no one responds, then
> > > 2. submit a patch to put an entry in feature-removal-schedule.txt giving a
> > >    description of what will be removed and when - and then flag it
> > >    with a patch to remove it.  If no one responds to that, then
> > > 3. the patch to remove it re-posted, and if no one objects it gets
> > >    merged.
> > > 
> > > So, if people care about bits of code _and_ they're not on the relevant
> > > subsystem mailing lists, they need to keep an eye on the feature removal
> > > file - otherwise they're in for nasty surprises.
> > 
> > I agree with the steps, but I'm not sure David knows about (or would be
> > following) those steps. Not to mention these devices are still readily
> > available used .. I wouldn't expect anyone to even remotely ponder
> > removing this code for at least another 10 years.. In order to even
> > start the process above there has to be some good probability that no
> > has the device or cares at all about the device..
> 
> Actually... no.  We've removed entire SoCs which have lost their
> maintainers well under this '10 years'.

In this case we have a maintainer (3 of them even)..

> One of the key decisions for removing code is the cost of keeping it
> in a buildable state when there's no one actively looking after it.
> If it has a high cost it'll get deleted much earlier...

I'm not trying to suggest rules for the entire ARM architecture .. In
this particular case it's totally uncalled for to even try to remove the
code.. I don't know the details of the case which your bringing up, but
it doesn't seem (from what you've said) similar to this one. These
devices are widely available, lots of developers and non-developers have
them, the devices are widely available for purchase (with kernels on
them), we have maintainers for the area where the code lives..

In the case your bringing up I could argue with you, but I really don't
know the circumstances.. To me I think it should be hard to remove code
for devices you can easily get a hold of..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

Add to Google