Re: [PATCH 4/4] mmc: Add mmc_host_<level> logging
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Joe Perches <joe@xxxxxxxxxxx>
- Subject: Re: [PATCH 4/4] mmc: Add mmc_host_<level> logging
- From: NamJae Jeon <linkinjeon@xxxxxxxxx>
- Date: Wed, 16 Nov 2011 10:14:04 +0900
- Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>, David Brown <davidb@xxxxxxxxxxxxxx>, Daniel Walker <dwalker@xxxxxxxxxx>, Bryan Huntsman <bryanh@xxxxxxxxxxxxxx>, Nicolas Pitre <nico@xxxxxxxxxxx>, Chris Ball <cjb@xxxxxxxxxx>, Guennadi Liakhovetski <g.liakhovetski@xxxxxx>, Ian Molton <ian@xxxxxxxxxxxxxx>, Bruce Chang <brucechang@xxxxxxxxxx>, Harald Welte <HaraldWelte@xxxxxxxxxxx>, Pierre Ossman <pierre@xxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx
- In-reply-to: <1321405049.21286.35.camel@Joe-Laptop>
2011/11/16 Joe Perches <joe@xxxxxxxxxxx>:
> On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
>> 2011/11/16 Joe Perches <joe@xxxxxxxxxxx>:
>> > Centralize the pr_<level> uses of mmc_hostname into specific
>> > mmc_host_<level> calls to allow a flexible presentation style
>> > and shorten the code a bit.
>
>> I don't know why pr_info should be surely replaced by mmc_host_info.
>> if it is needed for only host name, I think that existing
>> pr_info/err/debug is sufficient.
>
> Please trim your replies and read the patch description.
my concern is that they feel confuse when coder add print code because
they should use mmc_host<level> for hostname, and pr_<level> is used
in the other case.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux ARM Kernel]
[Linux ARM]
[Linux Omap]
[Fedora ARM]
[Linux for Sparc]
[IETF Annouce]
[Security]
[Bugtraq]
[Linux OMAP]
[Linux MIPS]
[ECOS]
[Asterisk Internet PBX]
[Linux API]