Re: [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Tue, 8 Nov 2011, Stephen Boyd wrote:

> Add support for DEBUG_LL on the 8660 and 8960 development boards.
> While we're here cleanup the uncompress.h code a bit. Avoid
> the use of readl/writel as those are Linux specific APIs that
> aren't guaranteed to work in the decompressor.
> Cc: Nicolas Pitre <nico@xxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Acked-by: Nicolas Pitre <nico@xxxxxxxxxx>

Independently from this patch, I was wondering about this code:

> +	.macro	senduart, rd, rx
> +	@ Write the 1 character to UARTDM_TF
> +	str	\rd, [\rx, #0x70]
> +#else
>  	teq	\rx, #0
>  	strne	\rd, [\rx, #0x0C]
> +#endif
>  	.endm

Why testing for zero in the #else part?  The upper level code should 
never call this macro with a null byte.

To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]