Re: [PATCH 02/20] mm: Add optional TLB flush to generic RCU page-table freeing
- To: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
- Subject: Re: [PATCH 02/20] mm: Add optional TLB flush to generic RCU page-table freeing
- From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
- Date: Thu, 28 Jun 2012 22:00:01 +1000
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Rik van Riel <riel@xxxxxxxxxx>, Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>, Mel Gorman <mel@xxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, Alex Shi <alex.shi@xxxxxxxxx>, "Nikunj A. Dadhania" <nikunj@xxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, Russell King <rmk@xxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Paul Mundt <lethal@xxxxxxxxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Kyle McMartin <kyle@xxxxxxxxxxx>, James Bottomley <jejb@xxxxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>
- In-reply-to: <1340881511.28750.19.camel@twins>
- List-id: <linux-arch.vger.kernel.org>
On Thu, 2012-06-28 at 13:05 +0200, Peter Zijlstra wrote:
>
> > Some embedded ppc's know about the lowest level (SW loaded PMD) but
> > that's not an issue here. We flush these special TLB entries
> > specifically and synchronously in __pte_free_tlb().
>
> OK, I missed that.. is that
> arch/powerpc/mm/tlb_nohash.c:tlb_flush_pgtable() ?
Yup.
> > > So even if the hardware did do speculative tlb fills, it would do
> them
> > > from the hash-table, but that's already cleared out.
> >
> > Right,
>
> Phew at least I got the important thing right ;-)
Yeah as long as we have that hash :-) The day we move on (if ever) it
will be as bad as ARM :-)
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Kernel]
[Kernel Newbies]
[x86 Platform Driver]
[Share Photos]
[Security]
[Netfilter]
[Bugtraq]
[Linux FS]
[Photo]
[Yosemite]
[Yosemite Discussion]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]