- Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system
- From: "Ted Ts'o" <tytso@xxxxxxx>
- Date: Mon, 14 Mar 2011 19:17:53 -0400
- Cc: G@xxxxxxxxx, Indan Zupancic <indan@xxxxxx>, Greg KH <greg@xxxxxxxxx>, Jonathan Nieder <jrnieder@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Sage Weil <sage@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Aneesh Kumar K. V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx, mtk.manpages@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, hch@xxxxxx, l@xxxxxxxxx
- In-reply-to: <20110314142032.b9523309.akpm@xxxxxxxxxxxxxxxxxxxx>
- Mail-followup-to: Ted Ts'o <tytso@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, G@xxxxxxxxx, Indan Zupancic <indan@xxxxxx>, Greg KH <greg@xxxxxxxxx>, Jonathan Nieder <jrnieder@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Sage Weil <sage@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Aneesh Kumar K. V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx, mtk.manpages@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, hch@xxxxxx, l@xxxxxxxxx
- References: <201103111255.44979.arnd@xxxxxxxx> <ffafd3ccb3fd1be7c40348c9cee84aef.squirrel@xxxxxxxxxxxxxxxxxxxx> <20110311235607.GB15853@elie> <9446ab1a2315c0d2476c30f8315a0503.squirrel@xxxxxxxxxxxxxxxxxxxx> <20110312021001.GA16833@elie> <20110312173217.GA24981@xxxxxxxxx> <1e597aedd3d7825dcc0630b1cf2399fa.squirrel@xxxxxxxxxxxxxxxxxxxx> <20110314131042.5a7fb32f.akpm@xxxxxxxxxxxxxxxxxxxx> <20110314211119.GC8120@xxxxxxxxx> <20110314142032.b9523309.akpm@xxxxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Mar 14, 2011 at 02:20:32PM -0700, Andrew Morton wrote:
> > I'm a bit nervous about exposing WB_SYNC_NONE to userspace, because
> > its semantics are *definitely* hard to describe. For example, at the
> > moment if you do a WB_SYNC_NONE writeback, the writeback code will
> > clamp the amount of data written back for each inode to
> > MAX_WRITEBACK_PAGES (1024) pages.
>
> Wha? It does? When did that get broken?
Oops, sorry, I misread the code in wb_writeback(). My bad! I
misinterpreted what write_chunk does in that function.
MAX_WRITEBACK_PAGES now really is the minimum amount of pages that
wb_writeback() will request the file system to write back. I'm not
sure why we bother with write_chunk any more, but it shouldn't be
doing any harm any more.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Home]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]