Re: [PATCH, v7] cgroups: introduce timer slack controller

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Thu, 3 Mar 2011, Li Zefan wrote:

> >> +unsigned long get_task_timer_slack(struct task_struct *tsk)
> >> +{
> >> +	struct cgroup_subsys_state *css;
> >> +	struct tslack_cgroup *tslack_cgroup;
> >> +	unsigned long ret;
> >> +
> >> +	rcu_read_lock();
> > 
> > Did you just remove the odd comment or actually figure out why you
> > need rcu_read_lock() here ?
> > 
> 
> It's necessary to protect against task exiting or task moving between cgroups.

I know, though after the last review I wanted to make sure, that the
author understands it as well and not just removed the odd comment
just because I ranted about it :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html