Re: [PATCH v2 3/5]add metadata_readahead ioctl in vfs

[Arnd Bergmann <arnd@xxxxxxxx>]

On Wednesday 05 January 2011 03:11:36 Shaohua Li wrote:
> > Did you notice the comment above the function? ;-)
> > 
> > You should really add the new ioctls to compat_sys_ioctl, not
> > to the COMPATIBLE_IOCTL() list, in order to make the behavior
> > consistent between 32 and 64 bit user space. The main difference
> > is that all ioctl commands that are hardcoded in the functions
> > get called before trying to call the file system specific
> > .ioctl method.

> Thanks, fixed them.

The patch you posted still uses COMPATIBLE_IOCTL. Wrong patch?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html