- Subject: [RFC][v8][PATCH 5/10]: Add target_pids parameter to alloc_pid()
- From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
- Date: Mon, 12 Oct 2009 21:51:42 -0700
- Cc: Oren Laadan <orenl@xxxxxxxxxxxxxxx>, serue@xxxxxxxxxx, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Pavel Emelyanov <xemul@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, mikew@xxxxxxxxxx, mingo@xxxxxxx, hpa@xxxxxxxxx, Nathan Lynch <nathanl@xxxxxxxxxxxxxx>, arnd@xxxxxxxx, peterz@xxxxxxxxxxxxx, Louis.Rilling@xxxxxxxxxxx, roland@xxxxxxxxxx, kosaki.motohiro@xxxxxxxxxxxxxx, randy.dunlap@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Containers <containers@xxxxxxxxxxxxxxxxxxxxxxxxxx>, sukadev@xxxxxxxxxx
- In-reply-to: <20091013044925.GA28181@xxxxxxxxxx>
- References: <20091013044925.GA28181@xxxxxxxxxx>
- User-agent: Mutt/1.5.18 (2008-05-17)
Subject: [RFC][v8][PATCH 5/10]: Add target_pids parameter to alloc_pid()
This parameter is currently NULL, but will be used in a follow-on patch.
Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
Acked-by: Serge Hallyn <serue@xxxxxxxxxx>
Reviewed-by: Oren Laadan <orenl@xxxxxxxxxxxxxxx>
---
include/linux/pid.h | 2 +-
kernel/fork.c | 3 ++-
kernel/pid.c | 9 +++++++--
3 files changed, 10 insertions(+), 4 deletions(-)
Index: linux-2.6/include/linux/pid.h
===================================================================
--- linux-2.6.orig/include/linux/pid.h 2009-09-10 10:19:20.000000000 -0700
+++ linux-2.6/include/linux/pid.h 2009-09-10 10:29:10.000000000 -0700
@@ -119,7 +119,7 @@ extern struct pid *find_get_pid(int nr);
extern struct pid *find_ge_pid(int nr, struct pid_namespace *);
int next_pidmap(struct pid_namespace *pid_ns, int last);
-extern struct pid *alloc_pid(struct pid_namespace *ns);
+extern struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids);
extern void free_pid(struct pid *pid);
/*
Index: linux-2.6/kernel/fork.c
===================================================================
--- linux-2.6.orig/kernel/fork.c 2009-09-10 10:19:20.000000000 -0700
+++ linux-2.6/kernel/fork.c 2009-09-10 10:29:10.000000000 -0700
@@ -940,6 +940,7 @@ static struct task_struct *copy_process(
int retval;
struct task_struct *p;
int cgroup_callbacks_done = 0;
+ pid_t *target_pids = NULL;
if ((clone_flags & (CLONE_NEWNS|CLONE_FS)) == (CLONE_NEWNS|CLONE_FS))
return ERR_PTR(-EINVAL);
@@ -1110,7 +1111,7 @@ static struct task_struct *copy_process(
goto bad_fork_cleanup_io;
if (pid != &init_struct_pid) {
- pid = alloc_pid(p->nsproxy->pid_ns);
+ pid = alloc_pid(p->nsproxy->pid_ns, target_pids);
if (IS_ERR(pid)) {
retval = PTR_ERR(pid);
goto bad_fork_cleanup_io;
Index: linux-2.6/kernel/pid.c
===================================================================
--- linux-2.6.orig/kernel/pid.c 2009-09-10 10:23:27.000000000 -0700
+++ linux-2.6/kernel/pid.c 2009-09-10 10:29:10.000000000 -0700
@@ -272,13 +272,14 @@ void free_pid(struct pid *pid)
call_rcu(&pid->rcu, delayed_put_pid);
}
-struct pid *alloc_pid(struct pid_namespace *ns)
+struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids)
{
struct pid *pid;
enum pid_type type;
int i, nr;
struct pid_namespace *tmp;
struct upid *upid;
+ int tpid;
pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
if (!pid) {
@@ -288,7 +289,11 @@ struct pid *alloc_pid(struct pid_namespa
tmp = ns;
for (i = ns->level; i >= 0; i--) {
- nr = alloc_pidmap(tmp, 0);
+ tpid = 0;
+ if (target_pids)
+ tpid = target_pids[i];
+
+ nr = alloc_pidmap(tmp, tpid);
if (nr < 0)
goto out_free;
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Home]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]