|
|
|
Re: [RFC PATCH 0/9] Remove useless on_each_cpu return value | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Fri, Jan 6, 2012 at 3:03 PM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote: > On Tue, 2012-01-03 at 16:19 +0200, Gilad Ben-Yossef wrote: >> on_each_cpu() returns as its own return value the return value of >> smp_call_function(). smp_call_function() in turn returns a hard >> coded value of zero. >> >> Some callers to on_each_cpu() waste cycles and bloat code space >> by checking the return value to on_each_cpu(), probably for >> historical reasons. > > hysterical raisins,, yumm! :-) > >> This patch set refactors callers to not test on_each_cpu() >> (fixed) return value and then refactors on_each_cpu to >> return void to avoid confusing future users. >> > > Seems sane enough, fwiw: > > Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> Thanks for the review :-) I just sent out a V2. No changes except I've added the needed signed-off-by. Gilad -- Gilad Ben-Yossef Chief Coffee Drinker gilad@xxxxxxxxxxxxx Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "Unfortunately, cache misses are an equal opportunity pain provider." -- Mike Galbraith, LKML -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html