Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, 6 May 2011 09:49:25 -0400
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote:
> > On Wed,  4 May 2011 20:13:37 +1200
> > Michael Cree <mcree@xxxxxxxxxxxx> wrote:
> > 
> > > The radeon drm code now relies on DMA_ERROR_CODE.  This defines
> > > it in alpha dma-mapping header to at least enable me to compile
> > > radeon drm/kms into kernel.
> > > 
> > > Signed-off-by: Michael Cree <mcree@xxxxxxxxxxxx>
> > > ---
> > >  arch/alpha/include/asm/dma-mapping.h |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > This isn't correct. The drivers should not use DMA_ERROR_CODE directly
> > (some architecture specific drivers use it though). Fix rademon
> > drm/kms instead.
> 
> What would be a proper value for non-existent bus addresses? As in the value
> had not been set? 0?

Zero is a valid DMA address for some devices.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]     [Linux Resources]

Powered by Linux