Re: [RFC PATCH 1/4] usb: add struct usb_hub_port to store port related members.

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Wed, 21 Mar 2012, Lan Tianyu wrote:

> >> hi alan:
> >> 	Great thanks for your review.
> >> 	But I still confuse about "You might as well add the child device pointer
> >> into your new data structure." Could you help me to make it clear? :)
> >> 	Do you mean add struct usb_device pointer toward the device attached to the
> >> port in the
> >> struct usb_hub_port? If yes,Why?
> >
> > Yes, that's what I mean.  It's a natural thing to do; the child device
> > is directly associated with the port.  It's better than allocating a
> > separate array for hdev->children.
> OK. That' mean that I should replace the hdev->children with 
> port_data->child_device.
> In the hub.c, the struct usb_hub_port can be visited and the child_device can be 
> accessed
> directly. Out of hub.c, I should provide function to return child pointer. Is 
> that right?

Right.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html