Re: [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty logging by cond_resched()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sun, 29 Apr 2012 18:20:37 +0300
Avi Kivity <avi@xxxxxxxxxx> wrote:

> > 	- cond_resched_lock() uses spin_needbreak(), and I am not sure if
> > 	  this still does rescheduling for alleviating mmu_lock contention
> > 	  without CONFIG_PREEMPT.
> 
> IMO that's a feature.  If kernel policy is not to lockbreak when
> !CONFIG_PREEMPT, then we should follow it, whether it's the right thing
> or not.  If it's the wrong thing, change it in the kernel proper.

Agreed.

Anyway, we need to alleviate mmu_lock contention on server machines, where we
usually do not select CONFIG_PREEMPT.

So I need to check the porpose of this API.

> while (1)
>    need_to_read_the_code_a_bit_more();

It's a pleasure!

Thanks,
	Takuya
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[KVM ARM]     [KVM ia64]     [KVM ppc]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux