Re: [PATCH 1/3v2] kvm-s390: Implement the directed yield (diag 9c) hypervisor call for KVM

[Christian Borntraeger <borntraeger@xxxxxxxxxx>]

> I think the code will me more readable, and less obvious that is was
> copied from kvm_vcpu_on_spin(), if you put all the processing outside
> the loop, except for matching the vpu itself.
> 
> So the code reads
> 
>    find a vcpu
>    obtain the task
>    do the yield
> 
> instead of looking like you're doing the processing for every vcpu.  The
> loop is just a slow lookup which might some day be replaced by a table
> lookup.

Ok. We might also have a kvm_vcpu_on_spin_directed in common code,
Would you prefer that? 

Christian

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html