Re: [PATCH 0/4] KVM: x86 emulator: Split decoder into separate functions

[Avi Kivity <avi@xxxxxxxxxx>]

On 04/23/2012 06:31 PM, Takuya Yoshikawa wrote:
> Takuya Yoshikawa (4):
>   KVM: x86 emulator: Introduce ctxt->op_prefix for 0x66 prefix
>   KVM: x86 emulator: Make prefix decoding a separate function
>   KVM: x86 emulator: Make opcode decoding a separate function
>

I don't see the benefit for the first three patches.  They add more
state, and don't encourage any reuse.  The current code is complicated,
but just splitting it doesn't really fix that.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html