- Subject: Re: [PATCH] kvm: don't call mmu_shrinker w/o used_mmu_pages
- From: Avi Kivity <avi@xxxxxxxxxx>
- Date: Sun, 22 Apr 2012 12:35:21 +0300
- Cc: Ying Han <yinghan@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Mel Gorman <mel@xxxxxxxxx>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Hillf Danton <dhillf@xxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, linux-mm@xxxxxxxxx, kvm@xxxxxxxxxxxxxxx, Marcelo Tosatti <mtosatti@xxxxxxxxxx>
- In-reply-to: <20120420151143.433c514e.akpm@linux-foundation.org>
- References: <1334356721-9009-1-git-send-email-yinghan@google.com> <20120420151143.433c514e.akpm@linux-foundation.org>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
On 04/21/2012 01:11 AM, Andrew Morton wrote:
> On Fri, 13 Apr 2012 15:38:41 -0700
> Ying Han <yinghan@xxxxxxxxxx> wrote:
>
> > The mmu_shrink() is heavy by itself by iterating all kvms and holding
> > the kvm_lock. spotted the code w/ Rik during LSF, and it turns out we
> > don't need to call the shrinker if nothing to shrink.
> >
>
> We should probably tell the kvm maintainers about this ;)
>
Andrew, I see you added this to -mm. First, it should go through the
kvm tree. Second, unless we misunderstand something, the patch does
nothing, so I don't think it should be added at all.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[KVM ARM]
[KVM ia64]
[KVM ppc]
[Spice Development]
[Libvirt]
[Libvirt Users]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Linux Kernel]
[Linux SCSI]
[XFree86]