Re: [PATCH] virtio_blk: Add help function to format mass of disks
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 04/11/2012 09:21 AM, Asias He wrote:
On 04/10/2012 11:53 PM, Michael S. Tsirkin wrote:On Tue, Apr 10, 2012 at 08:49:43AM -0700, Tejun Heo wrote:Hello, guys. On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:Why not use 'base' below? neither unit nor base change.Yes it's a bit strange, it was the same in Tejun's patch. Tejun, any idea?It was years ago, so I don't recall much. I think I wanted to use a variable name which signifies its role - I worked out the rather convoluted base number logic on paper first and I probably wanted to keep the distinctions. I don't think it really matters at this point tho. Just make sure those functions are marked deprecated so that no one else copies them. Thanks.I guess I'll keep it same so it's easier to deduplicate if someon wants to.
So, I'd keep this in the next version.
Why not fix it both in sd_format_disk_name() and virtblk_name_format(). Ren, mind to send v2 to drop the duplicate line?
I'll send v2 soon. -- Thanks, Ren -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html