Re: [PATCH v2] kvm: remove redundant registration of BSP's hv_clock area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 18/02/2014 11:09, Fernando Luis Vázquez Cao ha scritto:
These days hv_clock allocation is memblock based (i.e. the percpu
allocator is not involved), which means that the physical address
of each of the per-cpu hv_clock areas is guaranteed to remain
unchanged through all its lifetime and we do not need to update
its location after CPU bring-up.

Signed-off-by: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>
---

diff -urNp linux-3.14-rc3-orig/arch/x86/kernel/kvm.c linux-3.14-rc3/arch/x86/kernel/kvm.c
--- linux-3.14-rc3-orig/arch/x86/kernel/kvm.c	2014-02-18 19:01:08.103189324 +0900
+++ linux-3.14-rc3/arch/x86/kernel/kvm.c	2014-02-18 19:01:45.412494366 +0900
@@ -417,7 +417,6 @@ void kvm_disable_steal_time(void)
 #ifdef CONFIG_SMP
 static void __init kvm_smp_prepare_boot_cpu(void)
 {
-	WARN_ON(kvm_register_clock("primary cpu clock"));
 	kvm_guest_cpu_init();
 	native_smp_prepare_boot_cpu();
 	kvm_spinlock_init();
diff -urNp linux-3.14-rc3-orig/arch/x86/kernel/kvmclock.c linux-3.14-rc3/arch/x86/kernel/kvmclock.c
--- linux-3.14-rc3-orig/arch/x86/kernel/kvmclock.c	2014-01-20 11:40:07.000000000 +0900
+++ linux-3.14-rc3/arch/x86/kernel/kvmclock.c	2014-02-18 19:02:51.966823212 +0900
@@ -242,7 +242,7 @@ void __init kvmclock_init(void)
 	hv_clock = __va(mem);
 	memset(hv_clock, 0, size);

-	if (kvm_register_clock("boot clock")) {
+	if (kvm_register_clock("primary cpu clock")) {
 		hv_clock = NULL;
 		memblock_free(mem, size);
 		return;


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Thanks, applying to kvm/queue.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux