Google
  Web www.spinics.net

Re: [PATCH 2/2] KVM: PPC: Book3S: Call into C interrupt handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 26.04.2012, at 23:54, Scott Wood wrote:

> On 04/26/2012 05:19 AM, Alexander Graf wrote:
>> +	asm("mfmsr %0" : "=r"(msr));
> 
> Why not just mfmsr()?

Good question :).

> 
>> +	asm("bl 1f; 1: mflr %0" : "=r"(ip));
> 
> You'll want to tell the compiler that you're trashing LR.

Yikes. Yeah.

Keep in mind that this is a 1:1 copy from the booke code (read: I should merge those 2). So it's just as broken there.


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[KVM Development]     [KVM ARM]     [KVM ia64]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Photo]     [Video Projectors]     [PDAs]     [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Big List of Linux Books]

  Powered by Linux