Google
  Web www.spinics.net

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Feb 06, 2012 at 09:06:04PM +0100, Jan Kiszka wrote:
> On 2012-02-06 19:25, Marcelo Tosatti wrote:
> >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> >> index c38efd7..a1761ff 100644
> >> --- a/arch/x86/kvm/x86.c
> >> +++ b/arch/x86/kvm/x86.c
> >> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
> >>  		kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
> >>  		if (vcpu->cpu != cpu)
> >>  			kvm_migrate_timers(vcpu);
> >> -		vcpu->cpu = cpu;
> >>  	}
> > 
> > This is wrong, kvm_sched_in fails to see vcpu->cpu properly. Please
> > keep vcpu->cpu assignment in arch code.
> 
> True, but then kvm_sched_in is a better place for this assignment (as
> it's central), no?
> 
> Jan

Not necessarily. Arch code might want to have:

kvm_arch_vcpu_load()
{
	cpu = smp_processor_id();

	if (vcpu->cpu != cpu) {
		localize vcpu to cpu
		vcpu->cpu = cpu
	}

	call functions which use vcpu->cpu
}

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[KVM Development]     [KVM ARM]     [KVM ia64]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Photo]     [Video Projectors]     [PDAs]     [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Big List of Linux Books]

  Powered by Linux