Re: [PATCH V4 2/7] kvm tools: Generate SPAPR PPC64 guest device tree

[Matt Evans <matt@xxxxxxxxxx>]

On 31 Jan 2012, at 18:59, Pekka Enberg wrote:

> On Tue, Jan 31, 2012 at 8:34 AM, Matt Evans <matt@xxxxxxxxxx> wrote:
>> +static struct cpu_info cpu_power7_info = {
>> +       "POWER7",
>> +       power7_page_sizes_prop, sizeof(power7_page_sizes_prop),
>> +       power7_segment_sizes_prop, sizeof(power7_segment_sizes_prop),
>> +       32,             /* SLB size */
>> +       512000000,      /* TB frequency */
>> +       128,            /* d-cache block size */
>> +       128,            /* i-cache block size */
>> +       CPUINFO_FLAG_DFP | CPUINFO_FLAG_VSX | CPUINFO_FLAG_VMX
>> +};
> 
> Why don't you use C99 initializers here?

...just out of bad bad habit :)  Initialisers'd be cleaner, I'll convert them.


Thanks!


Matt

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html