Re: [PATCH V4 3/7] kvm tools: Add SPAPR PPC64 hcall & rtascall structure

[Pekka Enberg <penberg@xxxxxxxxxx>]

On Tue, Jan 31, 2012 at 8:34 AM, Matt Evans <matt@xxxxxxxxxx> wrote:
> +#define DEBUG_SPAPR_HCALLS

I suppose this shouldn't be defined by default?

> +#ifdef DEBUG_SPAPR_HCALLS
> +#define hcall_dprintf(fmt, ...) \
> +    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> +#else
> +#define hcall_dprintf(fmt, ...) \
> +    do { } while (0)
> +#endif

I don't expect you to fix this but this sort of thing really cries out
for userspace tracepoints.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html